Skip to content

Commit

Permalink
Fixed tests
Browse files Browse the repository at this point in the history
Signed-off-by: Patryk Strusiewicz-Surmacki <[email protected]>
  • Loading branch information
p-strusiewiczsurmacki-mobica committed Jul 15, 2024
1 parent 7569563 commit 588d2aa
Showing 1 changed file with 30 additions and 1 deletion.
31 changes: 30 additions & 1 deletion pkg/reconciler/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,26 @@ var (
}
`

mockctrl *gomock.Controller
mockctrl *gomock.Controller
tmpDir string
testConfig string
)

const operatorConfigEnv = "OPERATOR_CONFIG"

var _ = BeforeSuite(func() {
var err error
tmpDir, err = os.MkdirTemp(".", "testdata")
Expect(err).ToNot(HaveOccurred())
testConfig = tmpDir + "/config.yaml"
os.WriteFile(testConfig, []byte{}, 0o644) //empty config

Check failure on line 148 in pkg/reconciler/reconciler_test.go

View workflow job for this annotation

GitHub Actions / lint

Error return value of `os.WriteFile` is not checked (errcheck)
})

var _ = AfterSuite(func() {
err := os.RemoveAll(tmpDir)
Expect(err).ToNot(HaveOccurred())
})

func TestReconciler(t *testing.T) {
RegisterFailHandler(Fail)
mockctrl = gomock.NewController(t)
Expand Down Expand Up @@ -234,17 +251,20 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
Expect(r).To(BeNil())
})
It("create new reconciler", func() {
os.Setenv(operatorConfigEnv, testConfig)
frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl)
c := createClient()
frrManagerMock.EXPECT().Init().Return(nil)
r, err := NewNodeNetworkConfigReconciler(c, nil, logr.New(nil), "",
frrManagerMock, nl.NewManager(mock_nl.NewMockToolkitInterface(mockctrl)))
Expect(err).ToNot(HaveOccurred())
Expect(r).ToNot(BeNil())
os.Unsetenv(operatorConfigEnv)
})
})
Context("Reconcile() should", func() {
It("return no error if there is no config to reconcile", func() {
os.Setenv(operatorConfigEnv, testConfig)
frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl)
c := createClient()
frrManagerMock.EXPECT().Init().Return(nil)
Expand All @@ -254,8 +274,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
Expect(r).ToNot(BeNil())
err = r.Reconcile(context.TODO())
Expect(err).ToNot(HaveOccurred())
os.Unsetenv(operatorConfigEnv)
})
It("return no error if there is no config to reconcile", func() {
os.Setenv(operatorConfigEnv, testConfig)
frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl)
c := createClient()
frrManagerMock.EXPECT().Init().Return(nil)
Expand All @@ -265,8 +287,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
Expect(r).ToNot(BeNil())
err = r.Reconcile(context.TODO())
Expect(err).ToNot(HaveOccurred())
os.Unsetenv(operatorConfigEnv)
})
It("return error if cannot configure FRR", func() {
os.Setenv(operatorConfigEnv, testConfig)
os.Setenv(healthcheck.NodenameEnv, "test-node")
fakeNNC := &v1alpha1.NodeNetworkConfigList{}
err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC)
Expand All @@ -285,8 +309,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
err = r.Reconcile(context.TODO())
Expect(err).To(HaveOccurred())
os.Unsetenv(healthcheck.NodenameEnv)
os.Unsetenv(operatorConfigEnv)
})
It("return error if failed to reload FRR", func() {
os.Setenv(operatorConfigEnv, testConfig)
os.Setenv(healthcheck.NodenameEnv, "test-node")
fakeNNC := &v1alpha1.NodeNetworkConfigList{}
err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC)
Expand All @@ -306,8 +332,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
err = r.Reconcile(context.TODO())
Expect(err).To(HaveOccurred())
os.Unsetenv(healthcheck.NodenameEnv)
os.Unsetenv(operatorConfigEnv)
})
It("return error if cannot configure networking", func() {
os.Setenv(operatorConfigEnv, testConfig)
os.Setenv(healthcheck.NodenameEnv, "test-node")
fakeNNC := &v1alpha1.NodeNetworkConfigList{}
err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC)
Expand All @@ -327,6 +355,7 @@ var _ = Describe("NodeNetworkConfigReconciler", func() {
err = r.Reconcile(context.TODO())
Expect(err).To(HaveOccurred())
os.Unsetenv(healthcheck.NodenameEnv)
os.Unsetenv(operatorConfigEnv)
})
})
})
Expand Down

0 comments on commit 588d2aa

Please sign in to comment.