Vite translation #2750
Merged
Vite translation #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipKovachev
force-pushed
the
vite-translation
branch
from
025e1b1 to
b194db9
Compare
split translation into messages add missing translation add missing thank you messages resolve TS error
filipKovachev
force-pushed
the
vite-translation
branch
from
5e776b3 to
d05ac3a
Compare
filipKovachev
requested review from
silviyaboteva
and removed request for
a team
silviyaboteva
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Great work so far @filipKovachev,
The languages are switching as expected, but clicking over the 'Language' button an error in the console is thrown:
Invalid language selected: undefined
|
Fixed the error, a forgotten console.log statement was causing it |
silviyaboteva
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/telerik/kendo-react-private/issues/4867