Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todor vb reporting #1585

Merged
merged 25 commits into from
Jan 21, 2025
Merged

Todor vb reporting #1585

merged 25 commits into from
Jan 21, 2025

Conversation

todorarabadzhiev
Copy link
Collaborator

No description provided.

ighristov
ighristov previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ighristov ighristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of information about VB, I wonder how your lower back handled it!
Joke aside, thanks for the efforts and especially the dedicated samples.
I noticed a few typos and minor mistakes. Please fix them and merge to main.

...rts/report-designer-tools/web-report-designer/how-to-set-up-in-.net-framework-application.md Outdated Show resolved Hide resolved
...rts/report-designer-tools/web-report-designer/how-to-set-up-in-.net-framework-application.md Show resolved Hide resolved
embedding-reports/vb-reporting.md Outdated Show resolved Hide resolved
embedding-reports/vb-reporting.md Outdated Show resolved Hide resolved
DimitarNikolovv06
DimitarNikolovv06 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DimitarNikolovv06 DimitarNikolovv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DimitarNikolovv06 DimitarNikolovv06 merged commit b041a4e into master Jan 21, 2025
@DimitarNikolovv06 DimitarNikolovv06 deleted the todor-vb-reporting branch January 21, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitarNikolovv06 DimitarNikolovv06 DimitarNikolovv06 approved these changes

@ighristov ighristov Awaiting requested review from ighristov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@todorarabadzhiev @ighristov @DimitarNikolovv06