This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
UIPageViewController support, scaling & new delegate methods #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
August 4, 2016 13:55
This reverts commit db5a180.
# Conflicts: # TLYShyNavBar/ShyControllers/TLYShyViewController.m # TLYShyNavBar/TLYShyNavBarManager.m
Coledunsby
commented
Oct 25, 2016
| @@ -20,7 +20,7 @@ static inline CGFloat AACStatusBarHeight(UIViewController *viewController) | |||
| } | |||
|
|
|||
| // Modal views do not overlap the status bar, so no allowance need be made for it | |||
| if (viewController.presentingViewController != nil) | |||
| if (viewController.presentingViewController.presentedViewController == viewController) | |||
There was a problem hiding this comment.
This a better way to check if it's a modal. The current implementation fails in some cases (e.g. if a UITabBarController is pushed onto a UIViewController).
There was a problem hiding this comment.
@Coledunsby @telly Should be fixed in main repo! Thanks for your PR.
|
I'm trying to get back working on this, and after properly implementing better test cases, this is my top priority. |
|
This PR was very useful to me thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIPageViewControllerscaleproperty to scaleUINavigationBartitleViewon contract/expand similar to Instagram