Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 error route #793

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix 404 error route #793

merged 1 commit into from
Nov 7, 2023

Conversation

smilingkylan
Copy link
Contributor

Fixes #606

Description

  • Made the 404 route page component fit within the MainLayout component to maintain consistent layout / style

Test scenarios

-Checked on desktop and mobile

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit feaa8dd
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65478bab9550840008cbab80
😎 Deploy Preview https://deploy-preview-793--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit feaa8dd
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/65478bab3bdcde0008db1c30
😎 Deploy Preview https://deploy-preview-793--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/Error404.vue Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Nov 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: feaa8dd
Status: ✅  Deploy successful!
Preview URL: https://a9ea71ef.open-block-explorer.pages.dev
Branch Preview URL: https://606-error-page.open-block-explorer.pages.dev

View logs

Fix 404 error page styling

Fix unclickable links on 404 page issue
@donnyquixotic donnyquixotic merged commit c7dc17f into develop Nov 7, 2023
8 checks passed
@donnyquixotic donnyquixotic deleted the 606-error-page branch November 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants