#882 | clearing the address url parameter on internal transactions navigation #930
Conversation
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zkevm-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viterbo
changed the title
|
The deploy link is not working for me as on the image, when i click on the nav bar blockchain -> internal transactions after visiting https://deploy-preview-930--dev-mainnet-teloscan.netlify.app/txsinternal?a=0xa30b5e3c8Fee56C135Aecb733cd708cC31A5657a&page=7,10 2025-01-20.06-36-02.mov |
This is the interaction I get when I go to the Internal Transaction entry from the top menu. teloscan--internal-transactions.webm |
| toggleAllExpanded() { | ||
| this.allExpanded = !this.allExpanded; | ||
| this.rows.forEach((row) => { | ||
| row.expand = this.allExpanded; | ||
| }); | ||
| this.saveAllExpanded(); | ||
| }, | ||
| loadAllExpanded() { | ||
| // we look for the local Storage to see if the user has already expanded all the rows | ||
| const allExpanded = localStorage.getItem('allExpanded'); | ||
| if (allExpanded) { | ||
| this.allExpanded = allExpanded === 'true'; | ||
| } | ||
| }, | ||
| saveAllExpanded() { | ||
| // we save the state of the allExpanded variable in the local storage | ||
| localStorage.setItem('allExpanded', this.allExpanded); | ||
| }, |
| if(row.get("timeStamp") != null){ | ||
| long epoch = FormatterUtils.getEpochFromSQLTimestamp(row.get("timeStamp").toString()); | ||
| row.replace("timeStamp", epoch); | ||
| } | ||
|
|
There was a problem hiding this comment.
housekeeping. Code out of place
| clearPagination() { | ||
| this.pagination = { | ||
| ...this.pagination, | ||
| page: 1, | ||
| rowsPerPage: this.initialPageSize, | ||
| rowsNumber: 0, | ||
| }; | ||
| }, |
There was a problem hiding this comment.
clearPagination() - second part of the fix
| // each time the address changes, we clear the pagination | ||
| address() { | ||
| this.clearPagination(); | ||
| }, |
There was a problem hiding this comment.
watch address property - part of the fix (to the number of the total rows)
| } else { | ||
| // we are in the first page loading for the first time, so we clear the pagination | ||
| this.clearPagination(); | ||
| } |
There was a problem hiding this comment.
clearPagination() when there's no pagination parameter in the URL - the final part of the fix
| @@ -7,7 +7,6 @@ export default boot(({ app }) => { | |||
|
|
|||
| const defaultNetwork = Object.keys(evmSettings)[0]; | |||
| let network = new URLSearchParams(window.location.search).get('network') ?? process.env.NETWORK_EVM_NAME; | |||
| console.log('Multichain initMultichain()', { network, NETWORK_EVM_NAME: process.env.NETWORK_EVM_NAME }); | |||
Fixes #882
Description
The address parameter seemed to update after the query was made so even when you click on the internal transactions button (with no address filter) it does not change the filter until the second click to keep on navigating (It takes a delayed effect).
This PR adds a little bouncing to wait for the address parameter to update before performing the actual query so now it make it with the correct address filter.
Test scenarios
1 - visit this link with address filter:
https://deploy-preview-930--dev-mainnet-teloscan.netlify.app/txsinternal?a=0xa30b5e3c8Fee56C135Aecb733cd708cC31A5657a&page=7,10
2 - Click on Internal Transaction under Blockchain menu:
