Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-709 - audit logging pages for GCP #3047
EDU-709 - audit logging pages for GCP #3047
Changes from 8 commits
36af67d
6491eed
d6d1f4d
e58c1fa
4c95877
0927fff
8d76e91
dfae828
c26aec2
6dab0a3
68fe68b
ae022ca
e52062e
32d421b
f9fa253
00534a5
10b917a
627ede4
74f4c55
0db9129
056a043
3025d88
99e8a06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasonEgger could we keep that page (and the link to it) in a separate PR, and merge the rest ?
@alice-yin is going to double-check if we want the GCP PubSub details exposed yet; putting this as a separate PR will allow it to be ready to merge whenever, but to already have the reorg done.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I will get a separate PR setup with the drafts. I may not update the other files until after the merge to avoid unnecessary merge conflicts and to make rebasing easier, but as soon as we do the GCP merge I'll rebase and get the links setup again.
Does this work for y'all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the PR. #3080