Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-3170: Updates Worker Task Queue coverage for Nexus #3284

Merged
merged 6 commits into from
Jan 14, 2025
Merged

EDU-3170: Updates Worker Task Queue coverage for Nexus #3284

merged 6 commits into from
Jan 14, 2025

Conversation

fairlydurable
Copy link
Contributor

No description provided.

@fairlydurable fairlydurable requested a review from a team as a code owner January 9, 2025 20:41
@fairlydurable fairlydurable force-pushed the EDU-3170 branch 2 times, most recently from 99a5e48 to 619c5cd Compare January 9, 2025 20:44
@fairlydurable fairlydurable added the in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts label Jan 9, 2025
bergundy
bergundy approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had two minor comments, otherwise LGTM, thanks!

docs/encyclopedia/workers.mdx Outdated Show resolved Hide resolved
docs/encyclopedia/workers.mdx Outdated Show resolved Hide resolved
@fairlydurable fairlydurable added waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change and removed in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts labels Jan 14, 2025
@fairlydurable
Copy link
Contributor Author

Thank you @bergundy. All changes applied.

@fairlydurable
Copy link
Contributor Author

Now that the Worker page is broken down, will need to resolve conflicts.

@fairlydurable
Copy link
Contributor Author

Conflicts resolved and links tested

brianmacdonald-temporal
brianmacdonald-temporal approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good; well done.

@fairlydurable fairlydurable merged commit dab2797 into main Jan 14, 2025
3 checks passed
@fairlydurable fairlydurable deleted the EDU-3170 branch January 14, 2025 22:34
@fairlydurable fairlydurable removed the waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@brianmacdonald-temporal brianmacdonald-temporal brianmacdonald-temporal approved these changes

@prasek prasek Awaiting requested review from prasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fairlydurable @bergundy @brianmacdonald-temporal