Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-3751: Improves Issue UX #3290

Merged
merged 2 commits into from
Jan 17, 2025
Merged

EDU-3751: Improves Issue UX #3290

merged 2 commits into from
Jan 17, 2025

Conversation

fairlydurable
Copy link
Contributor

@fairlydurable fairlydurable commented Jan 13, 2025 •
edited
Loading

  • Added issue templates for reporting typos, content issues, improvement suggestions, and more.
  • Configured config.yml to link to the newly added templates.
  • Next step: Consensus that the topic types are right and the communication appropriate.

After design is agreed upon:

  • Next step: Testing the templates once merged.

    1. Review the config.yml for correct template linkage.
    2. Check each template (e.g., typos-and-grammar.md, content-issues.md) to ensure clarity and functionality.
    3. Once approved, merge and test on the default branch.

  • Added GitHub action to automatically add labels

  • Next step: Testing labels once merged

    1. Review the label-issues.yml for correct automation, including secret configuration
    2. Test with all templates and employee/community contributor

@fairlydurable fairlydurable requested a review from a team as a code owner January 13, 2025 20:42
@fairlydurable fairlydurable added the do-not-merge What it says on the label label Jan 13, 2025
@fairlydurable fairlydurable marked this pull request as draft January 13, 2025 20:43
@fairlydurable fairlydurable changed the title EDU-3751: Adds updated Issue UX EDU-3751: [DNM] Adds updated Issue UX Jan 13, 2025
@fairlydurable fairlydurable added the awaiting-team-collaboration Needs team support for developing material label Jan 13, 2025
@fairlydurable fairlydurable removed do-not-merge What it says on the label awaiting-team-collaboration Needs team support for developing material labels Jan 16, 2025
@fairlydurable
EDU-3751: Improves issue reporting templates
b34dcac 
Reviewed offsite so changes could be made and the forms tested
@fairlydurable fairlydurable added the waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change label Jan 17, 2025
@fairlydurable fairlydurable marked this pull request as ready for review January 17, 2025 14:47
@fairlydurable fairlydurable changed the title EDU-3751: [DNM] Adds updated Issue UX EDU-3751: Improves Issue UX Jan 17, 2025
brianmacdonald-temporal
brianmacdonald-temporal approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me.

@fairlydurable fairlydurable merged commit 065e4ff into main Jan 17, 2025
4 checks passed
@fairlydurable fairlydurable deleted the EDU-3751 branch January 17, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmacdonald-temporal brianmacdonald-temporal brianmacdonald-temporal approved these changes

Assignees
No one assigned
Labels
waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fairlydurable @brianmacdonald-temporal