Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-3800: Adds coverage of custom slot suppliers #3291

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

fairlydurable
Copy link
Contributor

SMEs: Spencer and Nikitha

@fairlydurable fairlydurable requested a review from a team as a code owner January 14, 2025 21:21
@fairlydurable fairlydurable added waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts labels Jan 14, 2025
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; nice job.

@fairlydurable fairlydurable removed waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts labels Jan 15, 2025
@fairlydurable fairlydurable merged commit d3478a3 into main Jan 15, 2025
3 checks passed
@fairlydurable fairlydurable deleted the EDU-3800 branch January 15, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants