Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-3817: Use value_set/unset to update search attributes #3300

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EddieWhi
Copy link

What does this PR do?

Update the docs for updating python search attributes.

Notes to reviewers

Stumbled across this issue when trying this out for the first time and deprecated method didn't cleanly validate through pyright. Assume this is the official mechanism for updating search attributes in python now?

@EddieWhi EddieWhi requested a review from a team as a code owner January 21, 2025 13:18
@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025

CLA assistant check
All committers have signed the CLA.

@fairlydurable fairlydurable added the community-contributor This PR was submitted external to Temporal label Jan 21, 2025
@fairlydurable fairlydurable changed the title Use value_set/unset to update search attributes EDU-3817: Use value_set/unset to update search attributes Jan 21, 2025
@fairlydurable fairlydurable added the in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts label Jan 21, 2025
@EddieWhi
Copy link
Author

Thanks for picking this up and tidying @fairlydurable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contributor This PR was submitted external to Temporal in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants