-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-3817: Use value_set/unset to update search attributes #3300
Open
EddieWhi
wants to merge
5
commits into
temporalio:main
Choose a base branch
from
EddieWhi:update-search-attribute-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairlydurable
added
the
community-contributor
This PR was submitted external to Temporal
label
Jan 21, 2025
fairlydurable
changed the title
Use value_set/unset to update search attributes
EDU-3817: Use value_set/unset to update search attributes
Jan 21, 2025
fairlydurable
added
the
in-tech-review
PR is blocked and waiting for tech review from Subject Matter Experts
label
Jan 21, 2025
Thanks for picking this up and tidying @fairlydurable :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contributor
This PR was submitted external to Temporal
in-tech-review
PR is blocked and waiting for tech review from Subject Matter Experts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the docs for updating python search attributes.
Notes to reviewers
Stumbled across this issue when trying this out for the first time and deprecated method didn't cleanly validate through pyright. Assume this is the official mechanism for updating search attributes in python now?