Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-1795: Update Prometheus data source setup in Grafana #3304

Merged
merged 1 commit into from
Jan 27, 2025
Merged

EDU-1795: Update Prometheus data source setup in Grafana #3304

merged 1 commit into from
Jan 27, 2025

Conversation

fairlydurable
Copy link
Contributor

Source of truth: Dallas

@fairlydurable fairlydurable requested a review from a team as a code owner January 23, 2025 22:37
@fairlydurable fairlydurable added work-in-progress This PR is not yet ready for technical or team review. Ideally it should be converted to a draft. in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts labels Jan 23, 2025
@fairlydurable
Copy link
Contributor Author

Any way to source a higher-quality image?

@fairlydurable fairlydurable added waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change and removed work-in-progress This PR is not yet ready for technical or team review. Ideally it should be converted to a draft. in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts labels Jan 27, 2025
brianmacdonald-temporal
brianmacdonald-temporal approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@fairlydurable fairlydurable merged commit 1523bbc into main Jan 27, 2025
4 checks passed
@fairlydurable fairlydurable deleted the EDU-1795 branch January 27, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelazhou32 angelazhou32 angelazhou32 left review comments

@brianmacdonald-temporal brianmacdonald-temporal brianmacdonald-temporal approved these changes

@jsundai jsundai jsundai approved these changes

@dallastexas92 dallastexas92 Awaiting requested review from dallastexas92

Assignees
No one assigned
Labels
waiting-on-team-review Work is complete and ticket is tech reviewed. Blocked by needing team review for non-trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlydurable @jsundai @angelazhou32 @brianmacdonald-temporal