Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-3846: Nexus circuit breaker docs #3305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

EDU-3846: Nexus circuit breaker docs #3305

wants to merge 4 commits into from
+87 −1

Conversation

prasek
Copy link
Contributor

@prasek prasek commented Jan 24, 2025

What does this PR do?

  • adds Nexus circuit breaker docs

@prasek prasek requested a review from a team as a code owner January 24, 2025 23:59
@fairlydurable
Copy link
Contributor

Hi @prasek and @bergundy -- is this one ready for docs now? All tech reviewed?

@bergundy
Copy link
Member

Yes, it's all reviewed on the technical side, @fairlydurable. There's a couple of suggestions that I'd leave up to @prasek's consideration.

@fairlydurable fairlydurable changed the title Nexus circuit breaker docs EDU-3846: Nexus circuit breaker docs Jan 27, 2025
@fairlydurable fairlydurable added cross-team This issue or PR was submitted from within Temporal in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts blocked-on-release These changes are waiting for official release okay labels Jan 27, 2025
@prasek
Copy link
Contributor Author

prasek commented Jan 28, 2025

Hi @fairlydurable -- all feedback has been resolved and it's ready for final docs review, thanks!

@fairlydurable fairlydurable mentioned this pull request Jan 29, 2025
Closed
fairlydurable added a commit that referenced this pull request Jan 29, 2025
@fairlydurable
EDU-3846: Updates nexus operations to add circuit breaking
5f56556 
- Added intro motivating and defining what circuit breaking is
- Added explanatory image
- Fixed typos
- Tightened grammar
- Incorporated changes from original PR #3305
@fairlydurable fairlydurable mentioned this pull request Jan 29, 2025
Open
@fairlydurable
Copy link
Contributor

Hi @prasek Because I couldn't make changes here since the branch is sourced on a non-temporal account, I put in PR 3311. Would you look that over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigozhou rodrigozhou rodrigozhou approved these changes

@bergundy bergundy bergundy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked-on-release These changes are waiting for official release okay cross-team This issue or PR was submitted from within Temporal in-tech-review PR is blocked and waiting for tech review from Subject Matter Experts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasek @fairlydurable @bergundy @rodrigozhou