Removed heardcoded 10 second timeout for an activity under test #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -363,17 +363,13 @@ private Result executeActivity( | |||
| localActivity)); | |||
|
|
|||
| try { | |||
| // 10 seconds is just a "reasonable" wait to not make an infinite waiting | |||
| return activityFuture.get(10, TimeUnit.SECONDS); | |||
| return activityFuture.get(); | |||
There was a problem hiding this comment.
Shouldn't the timeout be based on the activities timeout?
There was a problem hiding this comment.
I don't think anyone is using real activity timeouts in the TestActivityEnvironment.
Quinn-With-Two-Ns
approved these changes
Dec 18, 2023
|
Just wondering, when would this change be available? If it's on the next release, would it be possible to know approx. when that would be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed hardcoded 10-second timeout for TestActivityEnvironment.
Why?
We want to support unit testing activities that take longer than 10 seconds.
Reported at https://community.temporal.io/t/activities-run-in-tests-using-testactivityenvironment-intermittently-fails-with-java-util-concurrent-timeoutexception/10397/3