Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make group count stats configurable #2433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/config/development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ batchActionsDisabled: false
startWorkflowDisabled: false
hideWorkflowQueryErrors: false
refreshWorkflowCountsDisabled: false
WorkflowCountGroupByExecutionStatusEnabled: true
auth:
enabled: false
providers:
Expand Down
1 change: 1 addition & 0 deletions server/docker/config-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ batchActionsDisabled: {{ default .Env.TEMPORAL_BATCH_ACTIONS_DISABLED "false" }}
startWorkflowDisabled: {{ default .Env.TEMPORAL_START_WORKFLOW_DISABLED "false" }}
hideWorkflowQueryErrors: {{ default .Env.TEMPORAL_HIDE_WORKFLOW_QUERY_ERRORS "false" }}
refreshWorkflowCountsDisabled: {{ default .Env.TEMPORAL_REFRESH_WORKFLOW_COUNTS_DISABLED "false" }}
WorkflowCountGroupByExecutionStatusEnabled: {{ default .Env.TEMPORAL_WORKFLOW_COUNT_GROUP_BY_EXECUTION_STATUS_ENABLED "true" }}
cors:
cookieInsecure: {{ default .Env.TEMPORAL_CSRF_COOKIE_INSECURE "false" }}
allowOrigins:
Expand Down
3 changes: 3 additions & 0 deletions server/server/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ type (
HideWorkflowQueryErrors bool `yaml:"hideWorkflowQueryErrors"`
// Whether to disable refreshing workflow counts in UI
RefreshWorkflowCountsDisabled bool `yaml:"refreshWorkflowCountsDisabled"`
// Whether to enable the count group by execution status in UI
WorkflowCountGroupByExecutionStatusEnabled bool `yaml:"WorkflowCountGroupByExecutionStatusEnabled"`

// Forward specified HTTP headers from HTTP API requests to Temporal gRPC backend
ForwardHeaders []string `yaml:"forwardHeaders"`
HideLogs bool `yaml:"hideLogs"`
Expand Down
2 changes: 2 additions & 0 deletions src/lib/services/settings-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ export const fetchSettings = async (request = fetch): Promise<Settings> => {
hideWorkflowQueryErrors: !!settingsResponse?.HideWorkflowQueryErrors,
refreshWorkflowCountsDisabled:
!!settingsResponse?.RefreshWorkflowCountsDisabled,
countGroupByExecutionStatus:
!!settingsResponse?.WorkflowCountGroupByExecutionStatusEnabled,

showTemporalSystemNamespace: settingsResponse?.ShowTemporalSystemNamespace,
notifyOnNewVersion: settingsResponse?.NotifyOnNewVersion,
Expand Down
1 change: 1 addition & 0 deletions src/lib/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ export type SettingsResponse = {
StartWorkflowDisabled: boolean;
HideWorkflowQueryErrors: boolean;
RefreshWorkflowCountsDisabled: boolean;
WorkflowCountGroupByExecutionStatusEnabled: boolean;
ShowTemporalSystemNamespace: boolean;
NotifyOnNewVersion: boolean;
FeedbackURL: string;
Expand Down