Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Segmentation Fault in UnauthenticatedTenRPCCall in audit #2243

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix Segmentation Fault in UnauthenticatedTenRPCCall in audit #2243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42bef27
fixes to prevent seg fault
zkokelj Jan 8, 2025
bfd07ff
keep using pointer, but with explicit allocation
zkokelj Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tools/walletextension/rpcapi/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,24 @@ func UnauthenticatedTenRPCCall[R any](ctx context.Context, w *services.Services,

res, err := cache.WithCache(w.RPCResponsesCache, cfg, generateCacheKey(cacheArgs), func() (*R, error) {
return services.WithPlainRPCConnection(ctx, w.BackendRPC, func(client *rpc.Client) (*R, error) {
var resp *R
var resp R
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the reason why it had to be a pointer.
I'm wondering if we were to make this back a pointer and leave the if at the end, would it still seg-fault?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't remember why *R was used here.

After some research I think we can keep *R and do explicit allocation var resp *R = new(R) as it protects us from nil pointer dereference.
What do you think? Should I switch back to *R?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

var err error

// wrap the context with a timeout to prevent long executions
timeoutContext, cancelCtx := context.WithTimeout(ctx, maximumRPCCallDuration)
defer cancelCtx()

err = client.CallContext(timeoutContext, &resp, method, args...)
return resp, err
return &resp, err
})
})
audit(w, "RPC call. method=%s args=%v result=%s error=%s time=%d", method, args, res, err, time.Since(requestStartTime).Milliseconds())

if err != nil {
audit(w, "RPC call failed. method=%s args=%v error=%+v time=%d", method, args, err, time.Since(requestStartTime).Milliseconds())
return nil, err
}

audit(w, "RPC call succeeded. method=%s args=%v result=%+v time=%d", method, args, res, time.Since(requestStartTime).Milliseconds())
return res, err
}

Expand Down
Loading