Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management contract challenge period #2245

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Management contract challenge period #2245

merged 7 commits into from
Jan 15, 2025

Conversation

badgersrus
Copy link
Contributor

Why this change is needed

https://github.com/ten-protocol/ten-internal/issues/4443

What changes were made as part of this PR

  • Add a configurable delay to the management contract when adding state root to message bus
  • Script to read the challenge period from environment variable
  • Added new github action CHALLENGE_PERIOD var

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@badgersrus badgersrus force-pushed the will/challenge-period-v2 branch from 4f7731d to 85832d2 Compare January 13, 2025 16:14
StefanIliev545
StefanIliev545 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@StefanIliev545 StefanIliev545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure why are we going through a different launchable rather than having a deployment script for this.

@badgersrus badgersrus merged commit 1320a97 into main Jan 15, 2025
3 checks passed
@badgersrus badgersrus deleted the will/challenge-period-v2 branch January 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanIliev545 StefanIliev545 StefanIliev545 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badgersrus @StefanIliev545