Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple blobs/ rollups in the same tx #2249

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Jan 15, 2025

Why this change is needed

https://github.com/ten-protocol/ten-internal/issues/4483

What changes were made as part of this PR

  • If multiple rollups are found in the same block, check they have unique tx hashes before storing the block/ rollup
  • change the logger warning to trace as it will only reach that point if we have multiple rollups with unique txs in the block (ie in mem test)

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@badgersrus badgersrus changed the title Remove allowance of multiple rollups in a block Prevent multiple blobs/ rollups in the same tx Jan 15, 2025
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@badgersrus badgersrus merged commit f3a950c into main Jan 15, 2025
2 checks passed
@badgersrus badgersrus deleted the will/multiple-rollups-fix branch January 15, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants