Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove active sequencer nodetype #2254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

We have some annoying scenarios with the sequencer failover that are going to make thing fragile in the short term unless we address them.

It is problematic that the enclaves persist if they are active or not. It means if we failover then we have two active enclaves and the first one needs to be destroyed. This is not ideal while we are running with the current setup of host + 2xenclaves in a VM, the old turn it off and on again trick would no longer be available to us.

So I propose that enclaves do not persist that they are active. By the time a healthy one has restarted it would be treated as dead by the HA pool anyway so the persistence is never going to be useful. We could eventually do a check against mgmt contract or historical data that the sequencer ID has never published before before allowing to become active if that was the concern.

Eventually enclaves will be discarded/permanently excluded once they go down. The host will be able to start managing new enclaves dynamically without requiring initial config for them or a restart. But even in that end-state it doesn't help for the enclaves to persist that they were active I don't think.

What changes were made as part of this PR

Remove active/backup persisted node type separation. Introduce boolean for when the enclave is active.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant