Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified README to add notice of problematic Docker behaviour. #768

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

StefanIliev545
Copy link
Contributor

@StefanIliev545 StefanIliev545 commented Oct 27, 2022

Why is this change needed?

Docker Issue

The steps to build and run the project in the current README do not work with the latest version of docker

What changes were made as part of this PR:

Added a warning notice

🚨 Definition of done 🚨

  • Unit tests added to cover new or changed functionality
  • Docs pages updated to cover new or changed functionality
  • Changelog.md updated

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StefanIliev545 . First PR

@StefanIliev545 StefanIliev545 merged commit 021956d into main Oct 27, 2022
@StefanIliev545
Copy link
Contributor Author

Docker have supposedly fixed the issue in 4.13.1; We should retest and if confirmed update the readme.

@otherview otherview deleted the siliev/docker-arm64 branch February 10, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants