【feat】Optimize the web app build script to include checks for the bui…

…ld results, preventing partial successes. (#2058)
tencentmusic · Feb 14, 2025 · baae7f7 · baae7f7
1 parent e9d9c45
commit baae7f7
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/assembly/bin/supersonic-build.sh b/assembly/bin/supersonic-build.sh
@@ -35,12 +35,17 @@ function buildWebapp {
   chmod +x $projectDir/webapp/start-fe-prod.sh
   cd $projectDir/webapp
   sh ./start-fe-prod.sh
-  cp -fr  ./supersonic-webapp.tar.gz ${buildDir}/
   # check build result
   if [ $? -ne 0 ]; then
       echo "Failed to build frontend webapp."
       exit 1
   fi
+  cp -fr  ./supersonic-webapp.tar.gz ${buildDir}/
+  # check build result
+  if [ $? -ne 0 ]; then
+      echo "Failed to get supersonic webapp package."
+      exit 1
+  fi
   echo "finished building supersonic webapp"
 }
 

diff --git a/webapp/packages/chat-sdk/src/common/type.ts b/webapp/packages/chat-sdk/src/common/type.ts
@@ -178,6 +178,7 @@ export type QueryDataType = {
 export type ColumnType = {
   authorized: boolean;
   name: string;
+  nameEn: string;
   bizName: string;
   showType: string;
   type: string;

diff --git a/webapp/start-fe-dev.sh b/webapp/start-fe-dev.sh
@@ -19,7 +19,10 @@ cd ./packages/chat-sdk
 pnpm i
 
 pnpm run build
-
+if [ $? -ne 0 ]; then
+    echo "Failed to build chat sdk."
+    exit 1
+fi
 pnpm link --global
 
 cd ../supersonic-fe

diff --git a/webapp/start-fe-prod.sh b/webapp/start-fe-prod.sh
@@ -23,6 +23,10 @@ cd ./packages/chat-sdk
 pnpm i
 
 pnpm run build
+if [ $? -ne 0 ]; then
+    echo "Failed to build chat sdk."
+    exit 1
+fi
 
 pnpm link --global
 
@@ -33,6 +37,10 @@ pnpm link ../chat-sdk
 pnpm i
 
 pnpm run build:os-local
+if [ $? -ne 0 ]; then
+    echo "Failed to build supersonic-fe."
+    exit 1
+fi
 
 tar -zcvf supersonic-webapp.tar.gz ./supersonic-webapp