fix: cosine, l2 distance and external build for multilevel kmeans #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamoi
force-pushed
the
fix
branch
2 times, most recently
from
7a08e6b to
506936d
Compare
usamoi
force-pushed
the
fix
branch
5 times, most recently
from
10b9b80 to
9b693bb
Compare
|
@cutecutecat Can you review this? It changes structure of external build table so that scripts need modification. |
Signed-off-by: usamoi <[email protected]>
usamoi
changed the title
Merged
Signed-off-by: usamoi <[email protected]>
cutecutecat
approved these changes
Nov 7, 2024
| if vector_options.dims != vector.as_borrowed().dims() { | ||
| pgrx::error!("extern build: incorrect dimension, id = {id}"); | ||
| } | ||
| vectors.insert(id, rabitq::project(vector.slice())); |
There was a problem hiding this comment.
For cosine distance, function_normalize() or opfamily.preprocess() is required for centroids.
There was a problem hiding this comment.
For cosine distance,
function_normalize()oropfamily.preprocess()is required for centroids.
No. This should be done in sampling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.