Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nprob and parallel sample #46

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: nprob and parallel sample #46

merged 2 commits into from
Nov 8, 2024

Conversation

cutecutecat
Copy link
Member

@cutecutecat cutecutecat commented Nov 6, 2024 •
edited
Loading

  • nprobe argument at bench.py
  • in-memory parallel chunk sampling at train.py
  • pre-norm for cosine metric at train.py
  • chunk insert for large dataset at index.py

usamoi
usamoi reviewed Nov 6, 2024
View reviewed changes
bench/train.py Show resolved Hide resolved
@cutecutecat cutecutecat merged commit 165d9cd into main Nov 8, 2024
2 checks passed
@cutecutecat cutecutecat deleted the bench-nprobe branch November 14, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen left review comments

@usamoi usamoi usamoi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cutecutecat @VoVAllen @usamoi