-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: final class for tflite bindings #241
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
So that's actually a generated class :) When we run the ffi script (https://github.com/tensorflow/flutter-tflite/blob/main/ffigen_tensorflow_lite.yaml) this gets overridden. |
@PaulTR, I wonder if there is an estimated timeline for when the |
This should be a matter updating all the dependencies everywhere. What's happening is that ffigen is generating newer code than other aspects of the pubspec.yaml file are cool with. |
We can update the ffigen package to 8.0.0 and resolve this issue. This issue has been resolved after 8.0.0 version. https://pub.dev/packages/ffigen/changelog |
28df067
to
1863fd3
Compare
fix(ffigen): fix class type for tflite bindings
1863fd3
to
be97988
Compare
@PaulTR @chathurach gotcha! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #234
Upgraded ffigen, melos, flutter lint + add some help in read me using melos.
We can probably bump ffigen further thanks to #244