-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference mode and TF compatibility #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zsdonghao kindly resolve the file rename conflict and review PR. Thanks. |
zsdonghao
approved these changes
Sep 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Thanks a lot for code reorg.
Could you resolve the conflicts and then the PR is ready to merge to me. |
@zsdonghao ready to merge. |
zsdonghao
pushed a commit
that referenced
this pull request
Sep 28, 2018
* fixes tl global vars init deprecated issue #13 and impove code readability * inference mode and refactor * requirements and minor changes * moved inference to train * revert back file name to resolve merge conflict * rename script * some cleanup * move sess init
luomai
added a commit
that referenced
this pull request
Sep 28, 2018
zsdonghao
pushed a commit
that referenced
this pull request
Sep 28, 2018
* fixes tl global vars init deprecated issue #13 and impove code readability * inference mode and refactor * requirements and minor changes * moved inference to train * revert back file name to resolve merge conflict * rename script * some cleanup * move sess init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python main.py --help
].tqdm
progress bar for info while training.tf.contrib.rnn.BasicLSTMCell
totf.nn.rnn_cell.LSTMCell
since the former is deprecated.session config
to global scope.main.py
for ease of use.README
to add training and inference usage commands.requirements.txt
file.n.npz
tomodel.npz
since it is more standard.Note: Fixes #12 and #15