Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9370: removed ndpcc work around and debug code in sdpa decode and re-enabled CI #13299

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

caixunshiren
Copy link
Contributor

@caixunshiren caixunshiren commented Sep 30, 2024

Ticket

#9370

Problem description

ND pcc in sdpa decode.

What's changed

The bug exposed an issue in LLK and a work around has been added in LLK, so no work around is needed in the kernel itself.

Changes:

  • cleaned up code in kernel and removed dprint
  • re-enabled sdpa decode tests in CI

Checklist

Copy link
Contributor

@cglagovichTT cglagovichTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to reduce the number of tests since this will run in FD tests I believe

@caixunshiren caixunshiren merged commit e8245e0 into main Oct 1, 2024
6 checks passed
@caixunshiren caixunshiren deleted the flash-decode-fixnd branch October 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants