Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#11791
Problem description
I need to alter the linker scripts for XIP support - make sure PHDRS are as expected. But I noticed a few things that are a bit askew anyway, and these got exacerbated by @pgkeller 's recent changes
#define
and let the preprocessor expand as neededfoo = defined(foo) ? foo : .
idiom. Just define the appropriate value_Z11kernel_initv = _etext;
is particularly egregious -- it only makes sense in FW, and it's presuming_etext
is where the kernel starts -- just get the script to assign the right value itself..
in it..
What's changed
As above, no change in used functionality
Checklist