-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14080: Preprocess weights for Conv2D on Device #16750
Open
sankarmanoj-tt
wants to merge
17
commits into
main
Choose a base branch
from
smanoj/conv_device_weights
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankarmanoj-tt
force-pushed
the
smanoj/conv_device_weights
branch
from
January 15, 2025 10:53
fe919e2
to
e00b7ec
Compare
sankarmanoj-tt
force-pushed
the
smanoj/conv_device_weights
branch
2 times, most recently
from
January 29, 2025 13:34
6351705
to
7662eba
Compare
sankarmanoj-tt
requested review from
a team,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT,
llongTT,
nardoTT,
ayerofieiev-tt,
dmakoviichuk-tt,
cfjchu and
TT-BrianLiu
as code owners
January 30, 2025 12:05
llongTT
approved these changes
Jan 30, 2025
sankarmanoj-tt
force-pushed
the
smanoj/conv_device_weights
branch
from
January 31, 2025 08:38
7f3a9c0
to
c5c4540
Compare
@sankarmanoj-tt TODO: Re-enable transpose cast |
sankarmanoj-tt
force-pushed
the
smanoj/conv_device_weights
branch
from
February 3, 2025 10:12
c5c4540
to
6c6da4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14080
Problem description
Currently weights preprocessing takes place on the host, on a single thread. This is slow, especially when there is a large weights matrix, and Debug mode is enabled.
What's changed
The weights are loaded to the device in the same format as PyTorch. All other processing, including permute, padding, etc are done on the Device.
Checklist