Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0: Fix Packed unicast size #17462

Merged
merged 1 commit into from
Feb 2, 2025
Merged

0: Fix Packed unicast size #17462

merged 1 commit into from
Feb 2, 2025

Conversation

jbaumanTT
Copy link
Contributor

@jbaumanTT jbaumanTT commented Feb 1, 2025

Problem description

We're seeing a crash on MeshWorkloadTest.MeshWorkloadOnActiveEth

What's changed

We were always calculating the size with multicast subcommands, which is incorrect. Use the appropriate subcommand type instead.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

Copy link
Contributor

@tt-aho tt-aho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have unit tests for this case?

@jbaumanTT
Copy link
Contributor Author

Do we have unit tests for this case?

The MeshDevice tests caught this, but only on T3K, since otherwise there aren't enough active ethernet cores for the mismatch in sizes to appear. In a follow-up I want to move insert_write_packed_payloads into DeviceCommandCalculator so I can unit test it in DeviceCommandTest.

We were always calculating the size with multicast subcommands, which is incorrect.
@jbaumanTT jbaumanTT force-pushed the jbauman/fixt3kpacked branch from 8e5b485 to df27545 Compare February 1, 2025 19:34
@jbaumanTT jbaumanTT merged commit 69592bb into main Feb 2, 2025
202 of 208 checks passed
@jbaumanTT jbaumanTT deleted the jbauman/fixt3kpacked branch February 2, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants