#17203: Remove work executor from MeshDevice
#17475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omilyutin-tt
requested review from
cfjchu,
aliuTT,
tt-asaigal,
abhullar-tt,
pgkeller,
tt-aho,
tt-dma and
ubcheema
as code owners
cfjchu
approved these changes
Feb 1, 2025
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
…t#17475) ### Ticket tenstorrent#17203 ### Problem description `WorkExecutor` is needed for enabling `push_work` to run asynchronously. We don't want and don't need that for `MeshDevice`. ### What's changed Remove `WorkExecutor` member from `MeshDevice`. There is no change in behavior, as `WorkExecutor` was initialized in the synchronous mode - the work was executed inline either way. This PR simplifies the code, aligning us with the TTNN integration plan. ### Checklist - [X] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/13093222031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#17203
Problem description
WorkExecutoris needed for enablingpush_workto run asynchronously. We don't want and don't need that forMeshDevice.What's changed
Remove
WorkExecutormember fromMeshDevice. There is no change in behavior, asWorkExecutorwas initialized in the synchronous mode - the work was executed inline either way. This PR simplifies the code, aligning us with the TTNN integration plan.Checklist