#0: Update Llama3 PERF.md and llama3 vision PCC after cache regeneration #17505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtairum
requested review from
cglagovichTT,
yieldthought and
uaydonat
as code owners
cglagovichTT
approved these changes
Feb 3, 2025
mtairum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Llama3 CI regression.
The accuracy changes were expected, since we've regenerated the Llama3 cache files on CI. The cache regeneration was done with PR #17421, meaning that some of its changes will only be picked up after it gets merged.
The cache regeneration was done since the latest improvements on rounding hit main and we expected small differences to the runs.
However we did not expect accuracy to drop.
FIY @yieldthought
We'll investigate this further.