Support postgres v9.6 in docker #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
During a review of the ansible'role config changes, that differ from the default postgres config. Here other diffs seen (that you'ld get also with the latest master ANXS role): where'as in orig: other 'custom default' settings (possibly caused by old postgres version defaults): We should check the exact meaning of these settings, like:
|
* Changes to support docker deployments * Removing logic from template files * Fixing spaces * Reducing duplication for docker and non-docker deployments * Empty dictionary for admin_pwd in non-docker
…with exported postgres port not on 5432
lhoss
force-pushed
the
support_v9_6_in_docker
branch
from
d4c2850 to
83a2c4b
Compare
|
UPDATE: I rebased this PR to current master (+force pushed), after testing the whole functionality still works (it does), including it's not fixed for ansible >v2.2.x (thx to recent master fixes) 👍 |
Allow custom options to be added to postgresql.conf file
Added custom options in postgresql.conf file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP (plz do not merge (to master))
This is just a temp. branch (to live as long the 2 contained ANXS-PRs haven't been merged to upstream master!
fyi @vincepii