Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces Reader - provide version + track totals optimization #1331

Merged
merged 17 commits into from
Jan 17, 2025
Merged

Spaces Reader - provide version + track totals optimization #1331

merged 17 commits into from
Jan 17, 2025

Conversation

lesleydreyer
Copy link
Contributor

@lesleydreyer lesleydreyer commented Jan 10, 2025 •
edited
Loading

  • Make getESVersion optional instead of defaulting to 6
  • Allow adjusting track total hits & default to false to optimize
  • Use track_total_hits instead of trackTotalHits as both are supported but saw somewhere they're phasing out trackTotalHits for es 8

@lesleydreyer lesleydreyer changed the title Draft: Spaces Reader Version & Track Total Optimization Spaces Reader - provide version + track totals optimization Jan 15, 2025
jsnoble
jsnoble approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesleydreyer lesleydreyer merged commit dcb78ed into master Jan 17, 2025
15 checks passed
@lesleydreyer lesleydreyer deleted the spaces-reader-changes branch January 17, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesleydreyer @jsnoble