Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin node versions in matrix #22

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Unpin node versions in matrix #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f39eea
update node versions in matrix
sotojn Jul 24, 2024
e126e12
unpin node 22
sotojn Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/asset-build-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
# NOTE: Hard Coded Node Version array, should match array in test-asset.yml
node-version: [18.19.1, 20.11.1, 22.2.0]
node-version: [18, 20, 22]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
- uses: actions/setup-node@v3
with:
# NOTE: Hard Coded Node Version
node-version: '18.19.1'
node-version: '18'
registry-url: 'https://registry.npmjs.org'
- run: yarn setup
- run: ./scripts/publish.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/asset-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
# NOTE: Hard Coded Node Version array, should match array in build-and-publish-asset.yml
node-version: [18.19.1, 20.11.1, 22.2.0]
node-version: [18, 20, 22]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
uses: actions/setup-node@v3
with:
# NOTE: Hard Coded Node Version
node-version: '18.19.1'
node-version: '18'
# NOTE: Prevent python 3.12 breaking node-gyp installations in the kafka asset
# TODO: try default python again in the future
- name: Use Python 3.11
Expand Down