Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main/swi-prolog): continue even if ABI check fails #22742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertkirkman
Copy link
Contributor

@robertkirkman robertkirkman commented Jan 3, 2025

By default swipl will terminate if $PREFIX/lib/swipl/ABI does not contain the exact same string that swipl --abi-version prints. The error appears to be spurious, so this bypasses it, while printing a warning about what is happening if the check failed.

Fixes #22737

@Biswa96
Copy link
Member

Biswa96 commented Jan 3, 2025

It seems that the change complicates the build process. How about disabling the ABI check?

@robertkirkman
Copy link
Contributor Author

robertkirkman commented Jan 3, 2025

I agree, altering the behavior of the ABI check is a more robust solution, because that assumes that the $PREFIX/lib/swipl folder included with the package is going to work, and therefore skips the sanity check the upstream developer created. I will change this to be implemented using my patch from the issue thread instead.

@robertkirkman robertkirkman force-pushed the swi-prolog-fix-abi-file-32-bit branch from be98978 to 990d01a Compare January 3, 2025 07:40
@robertkirkman robertkirkman changed the title fix(main/swi-prolog): perform 2 hostbuilds for 32-bit targets fix(main/swi-prolog): continue even if ABI check fails Jan 3, 2025
@robertkirkman robertkirkman force-pushed the swi-prolog-fix-abi-file-32-bit branch from 990d01a to aab7991 Compare January 3, 2025 09:22
Copy link
Member

@Grimler91 Grimler91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for investigating the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SWI-Prolog install from Termux repositories don't work on arm 32 bit devices: ABI mismatch
3 participants