Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove ASM sub-module #2168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: remove ASM sub-module #2168

wants to merge 3 commits into from

Conversation

apeabody
Copy link
Collaborator

No description provided.

@apeabody apeabody force-pushed the ap/migrateasmwq branch 13 times, most recently from 99eb8c0 to c5de12c Compare November 1, 2024 22:47
@apeabody apeabody force-pushed the ap/migrateasmwq branch 4 times, most recently from 6bc5f80 to a33a3e1 Compare November 15, 2024 00:17
@apeabody apeabody changed the title feat!: migrate ASM feat!: transition ASM sub-module to example Dec 6, 2024
@apeabody apeabody marked this pull request as ready for review December 6, 2024 01:07
@apeabody apeabody requested review from ericyz, gtsorbo and a team as code owners December 6, 2024 01:07
@apeabody apeabody force-pushed the ap/migrateasmwq branch 4 times, most recently from 88469ed to 80530bd Compare December 13, 2024 22:20
@apeabody apeabody changed the title feat!: transition ASM sub-module to example feat!: transition ASM sub-module to example only Dec 13, 2024
@apeabody apeabody changed the title feat!: transition ASM sub-module to example only feat!: transition ASM sub-module to example Dec 23, 2024
@apeabody apeabody added the triaged Scoped and ready for work label Dec 26, 2024
@apeabody apeabody added the blocked Blocked by some other work label Dec 27, 2024
djazayeri
djazayeri reviewed Jan 2, 2025
View reviewed changes
examples/simple_zonal_with_asm/outputs.tf Outdated Show resolved Hide resolved
examples/simple_zonal_with_asm/README.md Outdated Show resolved Hide resolved
@apeabody apeabody marked this pull request as draft January 3, 2025 18:12
@apeabody apeabody self-assigned this Jan 3, 2025
@apeabody apeabody changed the title feat!: transition ASM sub-module to example feat!: transition ASM sub-module Jan 3, 2025
@apeabody apeabody force-pushed the ap/migrateasmwq branch 3 times, most recently from b88b793 to 088d632 Compare January 3, 2025 21:12
@apeabody apeabody changed the title feat!: transition ASM sub-module feat!: remove ASM sub-module Jan 3, 2025
@apeabody apeabody marked this pull request as ready for review January 24, 2025 21:50
@apeabody
Copy link
Collaborator Author

Hi @djazayeri - I'm planning to release v36 next week, let me know if you are comfortable with this being included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djazayeri djazayeri djazayeri left review comments

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

At least 1 approving review is required to merge this pull request.

Assignees

@apeabody apeabody

Labels
blocked Blocked by some other work triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @djazayeri