Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use existing resources and test DA directly #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Feb 11, 2025

Description

The code in https://github.com/terraform-ibm-modules/terraform-ibm-cloudpak-data is only a DA (no module). The DA contains a provider configuration and is not compatible with the for_each, count, and depends_on arguments, hence should not be consumed the way it is in the basic example. So we should remove the basic example and instead update the tests to directly test the DA code.

To do this, we will need to have code in the tests folder to provision the pre-req cluster (same way we do in other DA tests when working with existing resources).
I also notice the DA is not locked into exact provider versions. We should lock into an exact version to ensure consistency.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Feb 11, 2025
@jor2 jor2 requested a review from argeiger as a code owner February 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants