Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resource keys and service credentials #255

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

shemau
Copy link

@shemau shemau commented Feb 6, 2025

Description

#253

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau marked this pull request as draft February 6, 2025 17:16
@shemau
Copy link
Author

shemau commented Feb 6, 2025

This pull request is a first pass. It requires additional work, including tests and ibm_catalog.json updates which have not been started yet.

The new code is copied from terraform-ibm-cos for consistency and extended to support two services.

I will looking for guidance on providing two separate sets of outputs, by service; or one combined set of outputs. The combined set of outputs covering both services may be more consistent with other modules. The separate outputs may be good for something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant