Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use script run for running tests and linter. #1410

Closed
wants to merge 6 commits into from

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Feb 1, 2024

What this PR does / why we need it:

EXPERIMENTAL IDEA: use scripts to run Terramate tests.
Rationale: using it in Terramate itself can help us finding issues quickly and also gather experience using the feature.

While doing this I found bug #1409 so this PR depends on that fix.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for docs-terramate-io canceled.

Name Link
🔨 Latest commit 1f901f0
🔍 Latest deploy log https://app.netlify.com/sites/docs-terramate-io/deploys/65eb2dc1c952f80008d2b433

@i4ki i4ki force-pushed the i4k-add-internal-script branch from af573f3 to 3d3a6c3 Compare February 2, 2024 02:53
Copy link

github-actions bot commented Feb 2, 2024

metric: time/op
CloudReadLines-4: old 1.01ms ± 5%: new 0.99ms ± 3%: delta: 0.00%
CloudReadLine-4: old 6.98ms ± 3%: new 6.93ms ± 2%: delta: 0.00%
ListFiles-4: old 50.8µs ± 2%: new 50.6µs ± 1%: delta: -0.46%
Generate-4: old 2.50s ± 2%: new 2.51s ± 1%: delta: 0.00%
GenerateRegex-4: old 1.76s ± 2%: new 1.79s ± 2%: delta: 1.81%
TokensForExpressionComplex-4: old 1.26ms ± 0%: new 1.26ms ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 888ns ± 1%: new 895ns ± 0%: delta: 0.78%
TokensForExpressionStringWith100Newlines-4: old 22.3µs ± 1%: new 22.4µs ± 1%: delta: 0.32%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.45ms ± 0%: new 1.45ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.26ms ± 0%: new 1.26ms ± 0%: delta: 0.12%
PartialEvalComplex-4: old 431µs ± 0%: new 432µs ± 0%: delta: 0.18%
PartialEvalSmallString-4: old 3.65µs ± 1%: new 3.65µs ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 1.85ms ± 0%: new 1.86ms ± 1%: delta: 0.81%
PartialEvalHugeInterpolatedString-4: old 4.96ms ± 1%: new 4.88ms ± 1%: delta: -1.68%
PartialEvalObject-4: old 21.8µs ± 1%: new 21.6µs ± 1%: delta: -1.18%
TmAllTrueLiteralList-4: old 6.32ms ± 1%: new 6.26ms ± 0%: delta: -0.92%
TmAllTrueFuncall-4: old 162µs ± 1%: new 160µs ± 0%: delta: -0.97%
TmAnyTrueLiteralList-4: old 149ms ± 1%: new 147ms ± 0%: delta: -1.11%
TmAnyTrueFuncall-4: old 161µs ± 0%: new 161µs ± 0%: delta: -0.20%
TmTernary-4: old 2.86µs ± 1%: new 2.85µs ± 1%: delta: -0.36%
TmTry-4: old 51.8µs ± 0%: new 51.8µs ± 0%: delta: 0.00%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: 0.00%
GenerateRegex-4: old 963MB ± 0%: new 964MB ± 0%: delta: 0.10%
TokensForExpressionComplex-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 402kB ± 0%: new 402kB ± 0%: delta: 0.00%
TokensForExpression-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 353kB ± 0%: new 353kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: -0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: -0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 228 ± 0%: new 228 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 2.83k ± 0%: new 2.83k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 125 ± 0%: new 125 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: -0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: -0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 146 ± 0%: new 146 ± 0%: delta: 0.00%

@i4ki i4ki force-pushed the i4k-add-internal-script branch 2 times, most recently from ebc84d8 to 694d4c4 Compare February 26, 2024 17:52
Copy link

github-actions bot commented Feb 29, 2024

Preview of Project changes in 1f901f0

⚠️ preview is being created... please stand by!

@i4ki i4ki force-pushed the i4k-add-internal-script branch 7 times, most recently from afa5e96 to 3550a51 Compare March 4, 2024 02:18
i4ki added 3 commits March 8, 2024 14:46
This is a preparation for using parallel scripts in the repo.
The e2etests package has no real ordering dependency on the cmd and
cmd/terramate directories, then by moving it up we allow it running
in parallel with all other tests.

Signed-off-by: Tiago Natel <[email protected]>
@i4ki i4ki force-pushed the i4k-add-internal-script branch from 3550a51 to 3145abf Compare March 8, 2024 15:05
@i4ki i4ki force-pushed the i4k-add-internal-script branch from 3145abf to 4970e3d Compare March 8, 2024 15:20
@i4ki
Copy link
Contributor Author

i4ki commented Aug 11, 2024

closing in favor of another approach

@i4ki i4ki closed this Aug 11, 2024
@i4ki i4ki deleted the i4k-add-internal-script branch August 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant