Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Replace uutils-coreutils with uutils-replace packages #3056

Draft
wants to merge 9 commits into
base: frawhide
Choose a base branch
from

Conversation

ShinyGil
Copy link
Contributor

No description provided.

@ShinyGil ShinyGil marked this pull request as draft January 19, 2025 00:26
@ShinyGil ShinyGil marked this pull request as ready for review January 20, 2025 00:02
@ShinyGil ShinyGil changed the title Fix (uutils-coreutils): Add missing build dep, move to extras Fix (uutils-coreutils): Add missing build dep, fix build, move to extras Jan 20, 2025
@madonuko
Copy link
Member

are the dependency issues solved in this pr?

@ShinyGil
Copy link
Contributor Author

are the dependency issues solved in this pr?

I fixed a missing build dep and fixed Oniguruma stuff via the build flags, were there other dependency concerns I should work on?

@madonuko
Copy link
Member

if dnf doesn't complain about conflicts when installing this package then you're good

@ShinyGil
Copy link
Contributor Author

ShinyGil commented Jan 20, 2025

if dnf doesn't complain about conflicts when installing this package then you're good

Well, when I try to install them locally there's no obvious conflicts, I can try in a VM if needed? (I don't use uutils myself so I can't fully install locally.)
image

@ShinyGil
Copy link
Contributor Author

Tested main and subpackage installs on a VM, no dependency issues I could replicate.

@ShinyGil
Copy link
Contributor Author

The replace packages don't have dependency issues but they don't...work, they just conflict with the packages they try to replace. Since those are entirely the reason we kept this package, should we drop it...?

@ShinyGil ShinyGil marked this pull request as draft January 25, 2025 04:57
@ShinyGil ShinyGil changed the title Fix (uutils-coreutils): Add missing build dep, fix build, move to extras Remove: uutils-coreutils Jan 27, 2025
@ShinyGil
Copy link
Contributor Author

As the replace packages are broken (the reason this package was moved to Extras instead of dropped) and would potentially overwrite coreutils to fix, patches for Fedora being difficult to port in some cases, build issues (technically solved, but I could not get the package to build with Cargo which is the recommended build method, however upstream Fedora has it building with Cargo), I think dropping this package might be best at this point. This is a serious system component and parts of it being broken (even if just custom subpackages) or requiring hacky things to build worries me.

@ShinyGil ShinyGil removed the sync-f41 label Jan 27, 2025
@ShinyGil ShinyGil marked this pull request as ready for review January 27, 2025 12:01
@sadlerm4 sadlerm4 linked an issue Jan 27, 2025 that may be closed by this pull request
21 tasks
@sadlerm4
Copy link
Contributor

As the replace packages are broken

are the existing -replace packages also broken? and does the existing uutils-coreutils package in terra work?

@ShinyGil
Copy link
Contributor Author

As the replace packages are broken

are the existing -replace packages also broken? and does the existing uutils-coreutils package in terra work?

The package itself might work, I am not sure because I don't know how to test uutils enough, but yeah replace packages we kept it for do not. They just conflict with what they try to replace.

@korewaChino
Copy link
Member

korewaChino commented Jan 29, 2025

The packages should work as they're built the same. The only issue is that it conflicts with GNU coreutils (obviously)

@ShinyGil
Copy link
Contributor Author

The packages should work as they're built the same. The only issue is that it conflicts with GNU coreutils (obviously)

Fedora's is built with pure Cargo, shouldn't make a huge difference though?

@korewaChino
Copy link
Member

The packages should work as they're built the same. The only issue is that it conflicts with GNU coreutils (obviously)

Fedora's is built with pure Cargo, shouldn't make a huge difference though?

Yes. I meant the -replace packages. They're meant to conflict with coreutils and util-linux, because uutils is meant to do that.

@ShinyGil ShinyGil marked this pull request as draft January 29, 2025 08:22
@ShinyGil ShinyGil changed the title Remove: uutils-coreutils Change: Replace uutils-coreutils with uutils-replace packages Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Packages Currently Erroneously Conflicting With/Overriding Upstream
4 participants