optimize checking of progress

terrarium-earth · Jan 20, 2024 · 5257a59 · 5257a59
1 parent 16071a3
commit 5257a59
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/src/main/java/earth/terrarium/heracles/common/handlers/progress/QuestsProgress.java b/common/src/main/java/earth/terrarium/heracles/common/handlers/progress/QuestsProgress.java
@@ -36,8 +36,8 @@ public QuestsProgress(Map<String, QuestProgress> progress) {
             for (QuestTask<?, ?, ?> task : quest.tasks().values()) {
                 if (task.isCompatibleWith(taskType)) {
                     TaskProgress<?> progress = questProgress.getTask(task);
-                    Tag before = progress.progress().copy();
                     if (progress.isComplete()) continue;
+                    Tag before = progress.progress().copy();
                     progress.addProgress(taskType, ModUtils.cast(task), input);
                     if (progress.isComplete()) {
                         HeraclesEvents.TaskCompleteListener.fire(TaskEventTarget.create(task, player));