CI: use production release of Svelte 5 by default

testing-library · Oct 21, 2024 · 54217a6 · 54217a6
1 parent b5e0f3d
commit 54217a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -35,11 +35,11 @@ jobs:
           - { node: '20', svelte: '4', check: 'lint' }
           # `SvelteComponent` is not generic in Svelte 3, so type-checking only passes in >= 4
           - { node: '20', svelte: '4', check: 'types:legacy' }
-          - { node: '20', svelte: 'next', check: 'types' }
+          - { node: '20', svelte: '5', check: 'types' }
           # Only run Svelte 5 checks on latest Node
-          - { node: '20', svelte: 'next', check: 'test:vitest:jsdom' }
-          - { node: '20', svelte: 'next', check: 'test:vitest:happy-dom' }
-          - { node: '20', svelte: 'next', check: 'test:jest' }
+          - { node: '20', svelte: '5', check: 'test:vitest:jsdom' }
+          - { node: '20', svelte: '5', check: 'test:vitest:happy-dom' }
+          - { node: '20', svelte: '5', check: 'test:jest' }
 
     steps:
       - name: ⬇️ Checkout repo
@@ -53,7 +53,10 @@ jobs:
       - name: 📥 Download deps
         run: |
           npm install --no-package-lock
-          npm install --no-save svelte@${{ matrix.svelte }}
+          npm install --no-save svelte@${SVELTE_VERSION} @sveltejs/vite-plugin-svelte@${VITE_PLUGIN_VERSION}
+        env:
+          SVELTE_VERSION: ${{ matrix.svelte }}
+          VITE_PLUGIN_VERSION: ${{ matrix.svelte == '5' && '4' || '3' }}
 
       - name: ▶️ Run ${{ matrix.check }}
         run: npm run ${{ matrix.check }}

diff --git a/package.json b/package.json
@@ -95,7 +95,7 @@
   },
   "devDependencies": {
     "@jest/globals": "^29.7.0",
-    "@sveltejs/vite-plugin-svelte": "^3.1.1",
+    "@sveltejs/vite-plugin-svelte": "^3.0.0 || ^4.0.0",
     "@testing-library/jest-dom": "^6.3.0",
     "@testing-library/user-event": "^14.5.2",
     "@typescript-eslint/eslint-plugin": "^8.0.0",
@@ -111,7 +111,7 @@
     "eslint-plugin-promise": "^6.4.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-svelte": "^2.42.0",
-    "expect-type": "^0.20.0",
+    "expect-type": "^1.1.0",
     "happy-dom": "^15.7.3",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",