fix wasip1 on Windows GHA

Signed-off-by: Edoardo Vacchi <[email protected]>
tetratelabs · Feb 9, 2024 · 5b869c2 · 5b869c2
1 parent 6647c98
commit 5b869c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
@@ -370,6 +370,12 @@ jobs:
           cd ${{ env.STDLIB_TESTS }}
           make build.gowasip1
 
+      # The wasip1 stdlib tests are really path sensitive, so they expect a writeable /tmp directory to be available.
+      # We create it at the root of `C:`. This is normally only necessary on GHA Windows runners.
+      - if: ${{ matrix.os.name == 'Windows' }}
+        run: |
+          mkdir /c/tmp
+
       - name: Run built test binaries
         run: |
           cd ${{ env.STDLIB_TESTS }}

diff --git a/internal/integration_test/stdlibs/bench_test.go b/internal/integration_test/stdlibs/bench_test.go
@@ -78,7 +78,7 @@ var (
 
 			fsconfig := wazero.NewFSConfig().
 				WithDirMount(".", "/").
-				WithDirMount(os.TempDir(), "tmp")
+				WithDirMount(os.TempDir(), "/tmp")
 
 			c, stdout, stderr = defaultModuleConfig()
 			c = c.WithFSConfig(fsconfig).
@@ -109,8 +109,7 @@ var (
 			c, stdout, stderr = defaultModuleConfig()
 			c = c.WithFSConfig(
 				wazero.NewFSConfig().
-					WithDirMount(sysroot, "/").
-					WithDirMount(os.TempDir(), "tmp")).
+					WithDirMount(sysroot, "/")).
 				WithEnv("PWD", normalizedTestdir)
 
 			args := []string{fname, "-test.short", "-test.v"}