Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump golangci-lint to v1.55.2 #1879

Merged
merged 1 commit into from
Dec 19, 2023
Merged

deps: bump golangci-lint to v1.55.2 #1879

merged 1 commit into from
Dec 19, 2023

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Dec 19, 2023

Upgrading to go 1.21.5 causes the following golangci-lint error in the source tree (max()` new pseudo-function unrecognized):

❯ make format lint
../../../../sdk/go/src/net/http/internal/chunked.go:79:14: undefined: max (typecheck)
	cr.excess = max(cr.excess, 0)
	            ^
make: *** [lint] Error 1

Upgrading to the latest version of golangci-lint fixes the problem.

Signed-off-by: Edoardo Vacchi [email protected]

@mathetake mathetake merged commit 10bb61b into main Dec 19, 2023
58 checks passed
@mathetake mathetake deleted the bump-golangci-lint branch December 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

@mathetake mathetake Awaiting requested review from mathetake mathetake is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evacchi @mathetake