Changes Read to receive uint64 byte count. #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking good. can you proceed? |
|
I got a bit stuck with the test failures, then work/life got in the way. Let me try again. |
|
yeah cool, no rush anyway! |
Signed-off-by: Nuno Cruces <[email protected]>
Signed-off-by: Nuno Cruces <[email protected]>
Signed-off-by: Nuno Cruces <[email protected]>
|
This will definitely cause more churn than #2074, but if we want to do it, v2 is the right time. |
EclesioMeloJunior
pushed a commit
to ChainSafe/wazero
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Nuno Cruces <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2074 changed the type of
Size() uint64to we should probably change the type ofRead(offset uint32, byteCount uint64) ([]byte, bool). Otherwise, there's no API that gets entire buffer, if it covers the entire address range.As discussed on slack.