Handle negative grow pages to avoid shrinking memory #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
ncruces
reviewed
Mar 5, 2024
| @@ -256,7 +256,7 @@ func (m *MemoryInstance) Grow(delta uint32) (result uint32, ok bool) { | |||
|
|
|||
| // If exceeds the max of memory size, we push -1 according to the spec. | |||
| newPages := currentPages + delta | |||
| if newPages > m.Max { | |||
| if newPages > m.Max || int32(delta) < 0 { | |||
There was a problem hiding this comment.
Wouldn't newPages > m.Max || newPages < currentPages be clearer, or am I misunderstanding it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has existed for the very long time but thanks to the wazevo's aggressive bounds check
optimization, this has surfaced just now through fuzzing. I would say this is one of the most
terrible (yet not harmful in practice) bugs in the history of wazero...