compiler: fix ARMv8 regression introduced in #2345 #2365
+44
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nuno Cruces <[email protected]>
|
I clearly need to run tests with the race detector on. Sorry about that. |
|
What I am thinking about #2360 is that I am going to try out this branch, and see if it changes anything, then investigate the rest. Thanks for your responses! |
Signed-off-by: Nuno Cruces <[email protected]>
|
OK, so I guess this is ready. This delays the determination of whether to use the compiler or interpreter to Potentially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the performance regression introduced in #2345 by requiring ARMv8.1 when it is only strictly needed for
experimental.CoreFeaturesThreads.When I did #2345 I was trying to fix wasilibs/go-re2#136, and assumed (from the bug description) that these processors were really uncommon. It turns out that (e.g.) RaspberryPi 3 and 4 don't support these, and neither does the original Graviton (still in use by AWS).
Also, only Linux and FreeBSD allow us to figure out if the processor is an ARMv8.1 (we assume it is for macOS and take the chance on Windows, because 11 requires it). Still, the ARM compiler works fine on NetBSD too (I test this it in SQLite, as well as the ARM FreeBSD compiler).
I'm happy to reconsider the approach if this seems confusing.