fix issues with windowed pdf-viewer #3419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunderme
reviewed
Dec 16, 2023
| @@ -3898,6 +3913,7 @@ bool PDFDocument::closeElement() | |||
| else if (dwOverview && dwOverview->isVisible()) dwOverview->hide(); | |||
| else if (configManager->useEscForClosingEmbeddedViewer && isVisible()) { | |||
| // Note: avoid crash on osx where esc key is passed to hidden window | |||
| toggleFullScreen(false); | |||
There was a problem hiding this comment.
before closing the window we need to undo the changes done for fullscreen window mode.
There was a problem hiding this comment.
see 3rd list item of PR
sunderme
reviewed
Dec 16, 2023
| actionMagnify=configManager->newManagedAction(menuroot,menuView, "magnify", tr("&Magnify"), this, "", QList<QKeySequence>(),"magnifier-button"); | ||
| actionScroll=configManager->newManagedAction(menuroot,menuView, "scroll", tr("&Scroll"), this, "", QList<QKeySequence>(),"hand"); | ||
| actionMagnify=configManager->newManagedAction(menuroot,menuView, "magnify", tr("&Magnify"), pdfWidget, SLOT(magnifierClicked()), QList<QKeySequence>(),"magnifier-button"); | ||
| actionMagnify->setCheckable(true); |
There was a problem hiding this comment.
now magnify can also be unchecked in the menu ...
There was a problem hiding this comment.
ok, needs to be fixed
|
I find it hard to decipher what changes are supposed to do what, so I would prefer smaller PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves following issues found in the UI of the internal windowed pdf-viewer