Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with automatic translation #84

Open
Corvin4 opened this issue Dec 23, 2024 · 3 comments
Open

Issue with automatic translation #84

Corvin4 opened this issue Dec 23, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Corvin4
Copy link

Corvin4 commented Dec 23, 2024

Hi tfonteyn,

I noticed another issue. I'm using the app in German. The shelf "My Books" is called there "Meine Bücher". I entered several books to this shelf. Then I switched the language to English. The shelf is now called "My Books" but all other books are still in "Meine Bücher". I entered three more books to "My Books". As I turned back to German the books are staying in their shelf: 3 of them in "My Books", the others in "Meine Bücher". Now I have 2 "My Books" (in 2 different languages).

I can change this afterwards, but I think it shouldn't happen.

@tfonteyn
Copy link
Owner

I'll try it out tomorrow and get back to you

@tfonteyn tfonteyn added the bug Something isn't working label Dec 26, 2024
@tfonteyn
Copy link
Owner

aha.. I see what is going on. A little optimization where I don't load the default bookshelf from storage, but recreate it with the correct id but with the current language name... and when a book on that shelf is stored, the shelf is verified by NAME, not found and recreated .. and you get a new shelf by accident. (hope this makes sense).

It's a user-scenario I did not think about, and you're right, it should not happen... oops.

As you said, easy to fix by moving the books. Which reminds me: have you seen the menu-option Bücherregale zuweisen / Assign bookshelves from the node menus (the 3-dot menu buttons on each non-book line). That allows you to move a subset of books in one easy step.

I'll add this to the list for the next release; it's not worth it to create a bugfix release.

Thanks for reporting it.
Tom

tfonteyn pushed a commit that referenced this issue Dec 26, 2024
…have renamed it, or might have switched Locale (language)
@Corvin4
Copy link
Author

Corvin4 commented Dec 26, 2024

You're welcome. Your app is one of the best book management apps out there. If not the best. So I'm happy to be able to help make it even a bit better.
Thanks for the hint for assigning bookshelfs. I didn't see it before. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants