Changed ZoomIn ZoomOut Shortcuts to Ctrl+I/Ctrl+O #1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tackles #1127 |
|
I see, this is an underlying issue in electron. Seems it might only affect UK or German keyboards? Can anybody with an american keyboard confirm if this is an issue? electron/electron#15496 electron/electron#29996 |
|
@DanielTheMiller I can't speak for your app, but the Electron bug is definitely affecting American keyboards as well. |
|
Thank you, I ported the change in da9cb8e to TS! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ZoomIn ZoomOut Shortcuts to Ctrl+I / Ctrl+O (Or cmd+I/cmd+O on linux/mac)
I attempted to change the keyboard shortcut for zoom in to Ctrl+ over the current default Ctrl+Shift++ (which is labelled Ctrl++) but that wasn't binding for some reason.
A simple compromise that seems to work is to just use Ctrl+I Ctrl+O instead. The slightly less conventional zoom keyboard shortcut. There seems to be no conflicting keyboard shortcut.
I hope this is useful 😄